Changes between Initial Version and Version 1 of Ticket #34752, comment 2


Ignore:
Timestamp:
Jul 30, 2023, 9:35:04 AM (14 months ago)
Author:
Carlton Gibson

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34752, comment 2

    initial v1  
    11Hey Sam, thanks for the report. Yes, please do open a PR! (It being the weekend, I'd like to have a look at this properly once the PR is open.)
    22
    3 It would be nice to check that the cancelled error was handled explicitly, [https://github.com/django/django/pull/16603/files#diff-5f36804bb607499371385c6e3bbf30565150688c425d94ab0527af8af96a4f66R355 e.g. in PR for #33738], and maybe add an example similar to the [https://docs.djangoproject.com/en/dev/topics/async/#handling-disconnects async views disconnect example] to the [https://docs.djangoproject.com/en/dev/ref/request-response/#streaminghttpresponse-objects StreamingHttpResponse docs].
     3It would be nice to check that the cancelled error was handled explicitly, [https://github.com/django/django/pull/16603/files#diff-5f36804bb607499371385c6e3bbf30565150688c425d94ab0527af8af96a4f66R355 e.g. in PR for #33738] so similar in the streaming response iterator, and maybe add an example similar to the [https://docs.djangoproject.com/en/dev/topics/async/#handling-disconnects async views disconnect example] to the [https://docs.djangoproject.com/en/dev/ref/request-response/#streaminghttpresponse-objects StreamingHttpResponse docs].
    44
Back to Top