Context Navigation

Changes between Initial Version and Version 1 of Ticket #34716

Timestamp:

Jul 17, 2023, 5:01:57 AM (2 years ago)

Author:

Mariusz Felisiak

Comment:

Thanks for the report. It seems that FunctionTypeSerializer should use __qualname__ instead of __name__:

diff --git a/django/db/migrations/serializer.py b/django/db/migrations/serializer.py
index d88cda6e20..06657ebaab 100644

                class FunctionTypeSerializer(BaseSerializer):
         ):
             klass = self.value.__self__
             module = klass.__module__
             return "%s.%s.%s" % (module, klass.__name__, self.value.__name__), {
+            return "%s.%s.%s" % (module, klass.__qualname__, self.value.__name__), {
                 "import %s" % module
+            }
         # Further error checking

Would you like to prepare a patch? (regression test is required)

Ticket #34716
- Property Triage Stage Unreviewed → Accepted
- Property Summary Using subclass method as a callable for a field's default value results in wrong reference in the corresponding migration → Class methods from subclasses cannot be used as Field.default.

-              initial
+              v1
             return [cls.BASIC]
         capabilities = ArrayField(
           models.CharField(choices=Capability.choices, max_length=30, blank=True),
           null=True,
           default=Capability.default
+        )
+    capabilities = ArrayField(
+        models.CharField(choices=Capability.choices, max_length=30, blank=True),
+        null=True,
+        default=Capability.default
+    )