Admin missing breadcrumbs in app index

[Adam]

Breadcrumbs appear on the change list page (e.g. /admin/auth/group/ and /admin/auth/user/), as expected. However, they do not appear on the app index page (e.g. /admin/auth/) as they did in previous versions of Django.

[David Sanders]

Hi Adam,

Thanks for the suggestion but there was a lot of discussion around breadcrumbs and it was agreed to leave them out of the main index page in this PR: ​https://github.com/django/django/pull/12159

If you want you can start a discussion on the Django Forum or the mailing list on whether it would make sense to include it: https://code.djangoproject.com/wiki/DevelopersMailingList

Thanks!

[Adam]

Just to be clear, I am not talking about the MAIN index page, I am talking about the APP index page. The APP index page definitely looks like it's still meant to include breadcrumbs (​source), but it doesn't work anymore because of the way the "breadcrumbs" block was changed to include a <nav> element.

[David Sanders]

Hi Adam,

Apologies, thanks for the link you pasted (& your patience!), that does seem peculiar.

Reopening; after investigating I see that 872b61193b013a700ff88cf50f0eb2cf2c266ff7 changes behaviour causing the breadcrumbs in the app index to disappear.

[Mariusz Felisiak]

Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.

[Mariusz Felisiak]

Adam, thanks for the report! What do you think about the following patch? An empty <nav> shouldn't be an issue.

django/contrib/admin/templates/admin/index.html

@@ -7 +7 @@
 
 {% block bodyclass %}{{ block.super }} dashboard{% endblock %}
 
-{% block nav-breadcrumbs %}{% endblock %}
+{% block breadcrumbs %}{% endblock %}
 
 {% block nav-sidebar %}{% endblock %}
 

Would you like to prepare a patch via GitHub PR? (a regression test is required.)

[David Sanders]

I tested <nav aria-label="Breadcrumbs"></nav> using the macos screen reader and it didn't read the label out. 👍 Not sure how other screen readers would read it though? 🤔

The only concern I'd have with that is if someone adds to the nav-breadcrumbs block in base.html not realising it would impact index.html though sufficient test coverage would quickly highlight that 😊

[Mariusz Felisiak]

It's probably safer to have some duplication here.

​PR

[GitHub <noreply@…>]

In 9440f6b:

Fixed #34512 -- Restored breadcrumbs on admin app index view.

Thanks Adam (ataylor32) for the report.

Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.

[Mariusz Felisiak <felisiak.mariusz@…>]

In fffbf850:

[4.2.x] Fixed #34512 -- Restored breadcrumbs on admin app index view.

Thanks Adam (ataylor32) for the report.

Regression in 872b61193b013a700ff88cf50f0eb2cf2c266ff7.
Backport of 9440f6ba41e5e96458cd7949fc6d605ef5bd09e9 from main