Changes between Initial Version and Version 1 of Ticket #34459, comment 12
- Timestamp:
- Apr 5, 2023, 11:30:22 AM (13 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34459, comment 12
initial v1 4 4 > Ugh, we should probably not use `compose_sql` then 5 5 6 Escaping `%` sounds like a reasonable compromise to me, we already do this in schema editors, e.g. in [https://github.com/django/django/blob/38e63c9e61152682f3ff982c85a73793ab6d3267/django/db/backends/mysql/schema.py#L59-L60 MySQL] or [https://github.com/django/django/blob/38e63c9e61152682f3ff982c85a73793ab6d3267/django/db/backends/postgresql/schema.py#L59-L60 PostgreSQL]. Also, we avoid side-effect by providing the `quote_params` argument.6 Escaping `%` sounds like a reasonable compromise to me, we already do this in schema editors, e.g. in [https://github.com/django/django/blob/38e63c9e61152682f3ff982c85a73793ab6d3267/django/db/backends/mysql/schema.py#L59-L60 MySQL] or [https://github.com/django/django/blob/38e63c9e61152682f3ff982c85a73793ab6d3267/django/db/backends/postgresql/schema.py#L59-L60 PostgreSQL]. Also, we avoid side-effects by providing the `quote_params` argument.