Opened 18 years ago

Last modified 18 years ago

#3437 closed

djang.http.HttpResponse logic for _is_string is invalid — at Initial Version

Reported by: (removed) Owned by: Adrian Holovaty
Component: Core (Other) Version: dev
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

code currently does effectively thus-
if hasattr(content, 'iter'):

self._is_string = False
self._container = content

else:

self._is_string = True
self._container = [content]

Problem is that string objects support iteration.

Fix for it's simple; just do

if not isinstance(content, basestring) and hasattr(content, 'iter'):

(yes y'all prefer seperate patches, but it's a one liner ;)

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top