Changes between Version 1 and Version 2 of Ticket #34346, comment 5
- Timestamp:
- Feb 17, 2023, 5:14:37 PM (21 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #34346, comment 5
v1 v2 1 1 I am not that familiar with the codebase so I can't make any promises, so I guess it's for the best to leave another person with the bug. 2 2 3 I found out the issue happens because before the regression in `django.db.models.sql.compiler.SQLCompiler.get_order_by` would return a `Col` object wrapped inside an `OrderBy` object, but it now it returns `Ref` object wrapped in an `OrderBy` object which points to the correct column but its `as_sql` method returns the annotated value name instead of the unambiguous SQL.3 I found out the issue happens because before the regression in `django.db.models.sql.compiler.SQLCompiler.get_order_by` would return a `Col` object wrapped inside an `OrderBy` object, but it now it returns `Ref` object wrapped in an `OrderBy` object which points to the correct column but its `as_sql` method returns the annotated value name instead of the unambiguous `Col` SQL. 4 4 5 5 I am not sure to what extent is this information useful or if it's obvious, but as I said I am not that familiar with the codebase, and I am not sure what `Ref` objects are responsible for.