Changes between Initial Version and Version 3 of Ticket #34322


Ignore:
Timestamp:
Feb 9, 2023, 5:11:54 AM (18 months ago)
Author:
Adam Johnson
Comment:

Added more detail to description about possible failures

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34322

    • Property Severity NormalRelease blocker
    • Property Triage Stage UnreviewedAccepted
    • Property Summary ManifestStaticFilesStorage crashesManifestStaticFilesStorage crashes on commented JavaScript import statements
  • Ticket #34322 – Description

    initial v3  
    1 #32319 added module support to `ManifestStaticFilesStorage`. It can crash with imports in comments, which bundlers like Webpack can leave in.
     1#32319 added module support to `ManifestStaticFilesStorage`. It can crash with imports in comments, which are used for Typescript ([https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#import-types docs]) but don't necessarily resolve when code is bundled.
    22
    3 Example:
     3Example [https://github.com/bigskysoftware/htmx/blob/master/src/htmx.js from htmx]:
    44
    55{{{
     
    2020
    2121The regex should be adjusted to only select imports that are alone on a line, with whitespace.
     22
     23This may be a challenge as comments can be multi-line like:
     24
     25{{{
     26        /**
     27         * @param {HTMLElement} elt
     28         * @returns {import("./htmx").HtmxTriggerSpecification[]}
     29         */
     30}}}
Back to Top