Changes between Initial Version and Version 1 of Ticket #34254, comment 5


Ignore:
Timestamp:
Jan 16, 2023, 11:11:02 PM (17 months ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #34254, comment 5

    initial v1  
    55rajdesai24, sure thing please go ahead and submit a PR. Make sure to include a regression test demonstrating the problem that fails without the patch applied and passes with it applied.
    66
    7 I suggested adding one in `tests/annotations/tests.py` similarly to [https://github.com/django/django/commit/dd1fa3a31b4680c0d3712e6ae122b878138580c7#diff-1dc2d9f6410d5dbede47f9ea73f97bb4942f00ffddffccf0857919835149cbd8R213-R218 the one] added in dd1fa3a31b4680c0d3712e6ae122b878138580c7 but using `Exists` instead of `Subquery`.
     7I suggest adding one in `tests/annotations/tests.py` similarly to [https://github.com/django/django/commit/dd1fa3a31b4680c0d3712e6ae122b878138580c7#diff-1dc2d9f6410d5dbede47f9ea73f97bb4942f00ffddffccf0857919835149cbd8R213-R218 the one] added in dd1fa3a31b4680c0d3712e6ae122b878138580c7 but using `Exists` instead of `Subquery`.
Back to Top