Changes between Version 1 and Version 2 of Ticket #34176, comment 3


Ignore:
Timestamp:
Nov 22, 2022, 7:08:49 PM (18 months ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34176, comment 3

    v1 v2  
    1919Anyway, I submitted [https://github.com/django/django/pull/16321 this MR] for review which avoids a complex refactor of `get_select` that would have necessitated reference repointing.
    2020
    21 This means that group by reference will be disabled for annotations that conflict will a selected column name but I think that's an acceptable compromise given it should only have an incidence for with complex annotations that can't be collapsed assigned with ambiguous names. This a compromise we already took in #31377 as well and has a workaround for users that must get the group be reference; use an annotation name that doesn't conflict with an already selected column name.
     21This means that group by reference will be disabled for annotations that conflict with a selected column name but I think that's an acceptable compromise given it should only have an incidence on complex annotations that can't be collapsed that are assigned with ambiguous names.
     22
     23This a compromise we already made in #31377 and has a straightforward workaround for users that must get the group be reference for performance reasons; use an annotation name that doesn't conflict with an already selected column name.
Back to Top