Changes between Initial Version and Version 1 of Ticket #34069


Ignore:
Timestamp:
Oct 2, 2022, 5:50:48 AM (19 months ago)
Author:
sergioisidoro
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34069 – Description

    initial v1  
    55This is quite confusing, since `settings.LANGUAGE_CODE` is not "from the request", but from the application configuration, and it feels that the responsibility of falling back to the default language should lie in the Middleware, not in this function.
    66
     7Solution / Summary: `get_language_from_request` should return None, to communicate to the middleware that there was no language from request, and that the middleware should fallback to the default. Otherwise if the `get_language_from_request` returns "EN" we don't know if "EN" is actually a request preference, or because it came from the default `settings.LANGUAGE_CODE`
     8
Back to Top