Opened 2 years ago
Last modified 2 years ago
#34061 closed New feature
Model validations should be run on save() — at Version 1
| Reported by: | Aaron Smith | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | 4.0 |
| Severity: | Normal | Keywords: | model, validation, validations |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Most modern Django applications, at least as far as I have seen in 6 years of mostly working with Django, are headless API apps that do not use Forms. As a matter of fact, I have never used Forms in the several dozen django apps I've worked on, including several mission-critical APIs at multi-hundred-person companies.
Not running validations by default is a serious footgun that has ruined more than one developer's day. Yes, it's in the documentation. But the broad expectation is that a web framework will do this sort of thing by default without extra configuration or overrides. Model validations should function as expected by the naive regardless of how the model is saved.
Ideally the Model class should call full_clean() in it's save method. If this can't be done for backwards compatibility, I propose we add a new ValidatedModel class that subclasses Model. There should be a clear and obvious option to fulfill the basic and reasonable expectations of the new Django developer.
I'm more than happy to make this PR.