WKBReader.read() crashes on strings.

[Benoît Vinot]

Hi,

There is a potential type error in the implementation of the read method of the WKBReader class in contrib.gis. Here is a small example to create the problem:

from django.contrib.gis.geos.prototypes.io import _WKBReader
wkb='0101000020E6100000C07DD40B0FA8F5BF8794C5DD53DD4740' # <-- string
_WKBReader().read(wkb)

This code works fine:

from django.contrib.gis.geos.prototypes.io import _WKBReader
wkb='0101000020E6100000C07DD40B0FA8F5BF8794C5DD53DD4740'
_WKBReader().read(wkb.encode()) # <--- Converted into bytes

I suggest replacing the current implementation of this method by:

    def read(self, wkb):
        "Return a _pointer_ to C GEOS Geometry object from the given WKB."
        if isinstance(wkb, memoryview):
            wkb_s = bytes(wkb)
            return wkb_reader_read(self.ptr, wkb_s, len(wkb_s))
        elif isinstance(wkb, bytes):
            return wkb_reader_read_hex(self.ptr, wkb, len(wkb))
        elif isinstance(wkb, str):
            wkb_s = wkb.encode() # <------------------- Ensure bytes
            return wkb_reader_read_hex(self.ptr, wkb_s, len(wkb_s))
        else:
            raise TypeError

[Mariusz Felisiak]

Agreed, it doesn't work as ​documented.

[Benoît Vinot]

Thanks. Do you want me to create a PR?

[Leo Tom]

Replying to Benoît Vinot:

Thanks. Do you want me to create a PR?

Can I claim and work on this issue ?

[Mariusz Felisiak]

Replying to Benoît Vinot:

Thanks. Do you want me to create a PR?

Please do, thanks!

[Benoît Vinot]

Replying to Leo Tom:

Replying to Benoît Vinot:

Thanks. Do you want me to create a PR?

Can I claim and work on this issue ?

Yes, if you want. :-)

[Leo Tom]

PR: ​https://github.com/django/django/pull/16083

[Tim Graham]

Please uncheck "Needs tests" when you add one to the PR.

[Leo Tom]

Replying to Tim Graham:

Please uncheck "Needs tests" when you add one to the PR.

I just have to write a test in django/tests/gis_tests/geos_tests/test_io.py right. So all I have to do is inside the test03_wkbreader function add a string as well right?

[GitHub <noreply@…>]

In f3822d4a:

Fixed #34026 -- Fixed WKBReader.read() crash on string input.