Changes between Initial Version and Version 1 of Ticket #34022, comment 3


Ignore:
Timestamp:
Sep 19, 2022, 5:44:12 AM (2 years ago)
Author:
Jan Pazdziora

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34022, comment 3

    initial v1  
    1 Well, the change is backward incompatible in the sense that it changes behaviour, yes. But it my mind it fixes a problem which was introduced by some refactoring which changed behaviour for non-staff users by mistake.
     1Well, the change is backward incompatible in the sense that it changes behaviour, yes. But in my mind it fixes a problem which was introduced by some refactoring which changed behaviour for non-staff users by mistake.
    22
    33In the https://github.com/django/django/pull/16073#issuecomment-1250690063 comment I've now shown an alternative approach which would only cater to the non-staff case and as shown by the unmodified `test_client_logout_url_can_be_used_to_login` (just renamed to `test_logout_if_not_authenticated` to make its purpose more explicit), the behaviour for the unauthenticated case does not change.
Back to Top