Changes between Initial Version and Version 1 of Ticket #33975, comment 5


Ignore:
Timestamp:
Sep 2, 2022, 7:10:35 PM (2 years ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33975, comment 5

    initial v1  
    88
    99The proper solutions is likely to replace `Query.has_select_fields` by a class attribute that defaults to `False` and have `set_values` set it to `True` and make sure `Query.clone` carries the attribute over. This seems like a more durable options as that avoids trying to peek into internals to determine if a `values` call was performed.
     10
     11Gabriel, since you've already written a regression test, would you be interested in submitting a patch that takes the approach proposed above?
    1012 
Back to Top