Opened 22 months ago

Last modified 22 months ago

#33848 closed Cleanup/optimization

Migration StateApps.clone deepcopy too many objects — at Initial Version

Reported by: Iuri de Silvio Owned by: nobody
Component: Migrations Version: 4.0
Severity: Normal Keywords:
Cc: Simon Charette Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

StateApps.clone execute two slow deep copies. The first one copy all models. The second one copy app configs, that include all apps and the specific app models.

In my application, with ~250 models, this deepcopy is around 5% of migration time. I was able to cleanup StateApps before copy, to not copy all models and apps every operation again.

​https://github.com/django/django/blob/d4c5d2b52c897ccc07f04482d3f42f976a79223c/django/db/migrations/state.py#L683

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top