Opened 2 years ago
Last modified 2 years ago
#33765 closed Bug
ManifestStaticFilesStorage doesn't support trailing whitespace for JS source map references — at Initial Version
| Reported by: | Adam Johnson | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.staticfiles | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
#32383 added support for JS source map references, but the regex is incomplete. Browsers ignore trailing whitespace in source map references, but the regex we added did not allow for that. Whilst trailing whitespace is unlikely to be used, since source maps are normally generated by automated tools that shouldn't add it, we should ignore it to match browser behaviour.
Spotted during discussion on [this PR https://github.com/django/django/pull/15475] for a similar fix on CSS source map references.
(Also as discussed, I tested the inital space being a tab, or more than one space, and those options are not supported by Firefox.)
Note:
See TracTickets
for help on using tickets.