Changes between Initial Version and Version 1 of Ticket #33626, comment 3


Ignore:
Timestamp:
04/08/22 08:05:12 (6 months ago)
Author:
Himanshu Balasamanta
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33626, comment 3

    initial v1  
    55
    66Hi Carlton.
    7 I have opened the PR ​https://github.com/django/django/pull/15569, and have also modified the test that was supposed to throw error(schema.tests.SchemaTests.test_func_unique_constraint_lookups).
    8 There is no test that checks if the lookup stays in cache after unregistering it. In my PR, I have added an assert statement to check it in custom_lookups.tests.LookupTests.test_lookups_caching test. Running the test without clearing cache from _unregister_lookup will fail.
     7I have opened the PR ​https://github.com/django/django/pull/15569, and have also modified the test that was supposed to throw error( **schema.tests.SchemaTests.test_func_unique_constraint_lookups** ).
     8There is no test that checks if the lookup stays in cache after unregistering it. In my PR, I have added an assert statement to check it in **custom_lookups.tests.LookupTests.test_lookups_caching** test. Running the test without clearing cache from _unregister_lookup will fail.
    99>
    1010> * I was looking at [https://github.com/django/django/pull/6906 PR #6906] which added the cache clearing.
Back to Top