Changes between Initial Version and Version 1 of Ticket #33573, comment 5


Ignore:
Timestamp:
Mar 14, 2022, 9:28:44 AM (3 years ago)
Author:
Christopher Bailey

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33573, comment 5

    initial v1  
    11  Do you have an idea for implementation? As far as I'm aware this would require initializing two redis clients: async and non-async.
    22
    3 I kind of started to implement it, but then realized it was likely going to be a bigger issue then I though. But there is already an abstract RedisClient class that is a wrapper around the base redis.Redis class. It maintains connection polls and handles all of the core commands. It has methods for `get`, `set`, `add`, `touch`, `incr` that just calls `get_client` and makes a new client using the existing connection pull any time it is called.
     3I kind of started to implement it, but then realized it was likely going to be a bigger issue then I though. But there is already an abstract RedisClient class that is a wrapper around the base `redis.Redis` class. It maintains connection polls and handles all of the core commands. It has methods for `get`, `set`, `add`, `touch`, `incr` that just calls `get_client` and makes a new client using the existing connection pull any time it is called.
    44
    55For Async we can just add something like `get_async_client` and follow the same pattern within the class. I believe the connection poll should be able to be reused between the sync/async clients.
Back to Top