Changes between Initial Version and Version 1 of Ticket #33350, comment 5


Ignore:
Timestamp:
12/13/21 19:59:37 (7 months ago)
Author:
jason
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33350, comment 5

    initial v1  
    22> I don't see how this can be a regression, these decorators use functions from [https://docs.djangoproject.com/en/4.0/ref/utils/#module-django.utils.cache django.utils.cache] which are documented as accepting `HttpResponse` 🤔 Also `Response` defined in `django-rest-framework` is a subclass of `HttpResponse`.
    33
    4 [https://github.com/encode/django-rest-framework/blob/master/rest_framework/request.py#L140 Response] has never inherited from `HttpResponse` which has been the source of many issues like this even before 4.0. I am experiencing a lot of issues right now converting Django method views into DRF class-based views right now because all of the decorators keep breaking.
     4[https://github.com/encode/django-rest-framework/blob/master/rest_framework/request.py#L140 Request] has never inherited from `HttpRequest` which has been the source of many issues like this even before 4.0. I am experiencing a lot of issues right now converting Django method views into DRF class-based views right now because all of the decorators keep breaking.
Back to Top