Changes between Initial Version and Version 1 of Ticket #33346, comment 6


Ignore:
Timestamp:
Dec 8, 2021, 9:30:41 AM (3 years ago)
Author:
Baptiste Mispelon

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #33346, comment 6

    initial v1  
    11PR here: https://github.com/django/django/pull/15165
    22
    3 I went with the `isinstance` check wich seems a bit more robust since `forms` seems like quite a common attribute name and might catch other non-formset things.
     3~~I went with the `isinstance` check wich seems a bit more robust since `forms` seems like quite a common attribute name and might catch other non-formset things.~~
     4I went with `hasattr(context[formset], 'forms')` because the `isinstance` check broke some admin tests (`InlineAdminFormSet` is not a subclass of `BaseFormset` 😿 ).
Back to Top