Changes between Initial Version and Version 1 of Ticket #33174, comment 6


Ignore:
Timestamp:
Nov 24, 2023, 6:23:02 PM (10 months ago)
Author:
Jacob Fredericksen

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33174, comment 6

    initial v1  
    1 I think this should be revisited. Python 3.12 introduces new syntax for generic classes without explicit inheritance from typing.Generic (https://docs.python.org/3/whatsnew/3.12.html#pep-695-type-parameter-syntax), so having to trick Django by adding verbose TYPE_CHECKING conditionals and explicit Generic inheritance is a bummer. Removing typing.Generic from the list of bases in the migration file seems to work just fine, though.
     1I think this should be revisited. Python 3.12 introduces new syntax for generic classes without explicit inheritance from typing.Generic (https://docs.python.org/3/whatsnew/3.12.html#pep-695-type-parameter-syntax), so having to trick Django by adding verbose TYPE_CHECKING conditionals and explicit Generic inheritance is a bummer. Removing typing.Generic from the list of bases in the migration file seems to work well, though.
Back to Top