TestClient doesn't follow redirects that only contain a query string correctly.

[Jaap Roes]

While running a projects test suite on Django 4.0a1 (using Python 3.8) some tests unexpectedly started failing.

We have a FormView that defines the get_success_url method as follows:

def get_success_url(self):
    """
    Redirect to self
    """
    success = urllib.parse.urlencode({'success': self.n_deleted})
    return f'?{success}'

In actual browsers this results in a redirect to the original request's path with the querystring attached. The Django TestClient behaved the same way, but after the update to Django 4.0a1 it suddenly redirects to /?success=1.

This seems to be caused by the fix for #32790

[Jaap Roes]

Looking at #32790 it seems that there should also be a check that url.netloc isn't empty before setting path to '/'

[Carlton Gibson]

Hey Jaap — I didn't look in depth yet, but that sounds right. Do you want to make a patch?
Thanks.

[Jaap Roes]

I'll look into fixing this tomorrow

[Jaap Roes]

​PR

[Carlton Gibson <carlton@…>]

In b1bf8c8a:

Fixed #33132 -- Fixed test client handling of querystring only redirects.

Regression in 1e5aa8e1c79252cc810af21294a6e945d11d37b3.

[Carlton Gibson <carlton.gibson@…>]

In 5d36af6f:

[4.0.x] Fixed #33132 -- Fixed test client handling of querystring only redirects.

Regression in 1e5aa8e1c79252cc810af21294a6e945d11d37b3.

Backport of b1bf8c8a4ba04049dc19217bf0e876488a4fae3c from main