"Show all" is ambiguous

[Richard Laager]

The admin interface used "Show all" with two different meanings. One is to disable pagination (a query string of ?all=). The other is to disable filters (a query string of ?), when show_full_result_count is False.

I propose changing the latter to "Clear search" and have submitted a PR here:
​https://github.com/django/django/pull/14844

[Mariusz Felisiak]

IMO, "Show all" is more accurate, because it also clears filters, not only "Search". Also, "Show all" links appear in different places which makes them sufficiently distinguishable:

It's also ​documented.

[Richard Laager]

Fair enough. I didn't realize it cleared filters too. (Edit: I obviously should have realized this, since I noted the query string was empty.)

Part of my motivation here is that I'm upgrading from an old version of Django. It showed the pagination at the top of the page too, so there was a "Show all" link near the top of the page previously, and there is now, but they have different behaviors. I didn't expect this argument to carry much weight at this point, though, as people should be through this change already if they're staying on supported versions.

I closed the associated PR.