Opened 4 years ago

Last modified 4 years ago

#33061 closed Bug

ValueError not raised for incr / decr with negative delta for some backends? — at Version 1

Reported by: Chris Jerdonek Owned by: nobody
Component: Core (Cache system) Version: 3.2
Severity: Normal Keywords:
Cc: Sondre Lillebø Gundersen Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no
Pull Requests:14814 merged, 14810 merged

Description (last modified by Chris Jerdonek)

I was looking at the code for some of the cache backends, and I noticed that in a couple places, it looks like ValueError isn't being raised when it should be. This is in the ​incr() and ​decr() methods of BaseMemcachedCache when delta is less than zero. The commit where this code was added is here: ​https://github.com/django/django/commit/79dd751b0b9e428bf386d7304f442fa9815fdbba

This is just by looking at the code, so I could be wrong. But I wanted to flag it.

Change History (1)

comment:1 by Chris Jerdonek, 4 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top