Changes between Initial Version and Version 1 of Ticket #32940, comment 2
- Timestamp:
- Jul 18, 2021, 4:03:46 PM (3 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #32940, comment 2
initial v1 1 1 The `squash` argument was added in d3f00bd5706b35961390d3814dd7e322ead3a9a3. It seems to have been unused since it was introduced. (I didn't find `squash=False` anywhere.) 2 2 3 The `if self.connector == conn_type and data in self.children:` line had the first half of the expression added recently in b81c7562fc33f50166d5120138d6398dc42b13c3. Interestingly this was actually fixing a regression in d3f00bd5706b35961390d3814dd7e322ead3a9a3 as prior to that commit the condition was the same! 3 The `if self.connector == conn_type and data in self.children:` line had the first half of the expression added recently in b81c7562fc33f50166d5120138d6398dc42b13c3. Interestingly this was actually fixing a regression in d3f00bd5706b35961390d3814dd7e322ead3a9a3 as prior to that commit the condition was the same! The bug had originally been addressed in c127f0117d75220e346625cd8a009fb6a317ece1. 4 4 5 It'd probably be a good idea to see if Simon can cast an eye over this .5 It'd probably be a good idea to see if Simon can cast an eye over this just to make sure we're not going to reintroduce some problem.