Opened 3 years ago

Last modified 3 years ago

#32765 closed Cleanup/optimization

Label for ReadOnlyPasswordHashWidget points to non-labelable element. — at Version 3

Reported by: David Sanders Owned by: nobody
Component: contrib.auth Version: 3.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by David Sanders)

In the admin, the label element for the ReadOnlyPasswordHashWidget widget has a 'for' attribute which points to a non-labelable element, since the widget just renders text, not an input. There's no labelable element for the widget, so the label shouldn't have a 'for' attribute.

Change History (3)

comment:1 by David Sanders, 3 years ago

Has patch: set

comment:2 by Mariusz Felisiak, 3 years ago

Needs tests: set
Summary: Label for ReadOnlyPasswordHashWidget points to non-existent HTML IDLabel for ReadOnlyPasswordHashWidget points to non-labelable element.
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

Agreed, currently it's associated with <div> which is not a labelable element, see spec.

PR

comment:3 by David Sanders, 3 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top