Changes between Initial Version and Version 1 of Ticket #32508, comment 23


Ignore:
Timestamp:
Jun 2, 2021, 10:17:20 PM (3 years ago)
Author:
Jacob Walls

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32508, comment 23

    initial v1  
    44Thanks for your interest. Daniyal handled the bulk of what was left here in [https://github.com/django/django/pull/14173 PR 14173], so if you want to tackle the rest, be sure to skip the django.db module, which was the focus of that PR.
    55
    6 Toward getting started, this is a great time to learn about grep, e.g. `grep 'assert\s' django/* -r`. Here's what's left excluding django.db and the test suite itself:
     6Toward getting started, this is a great time to learn about grep, e.g. `grep 'assert\s' django/* -r`. Below is what's left excluding django.db and the test suite itself.
     7
     8The work to finish this off is to decide which ones remaining are worth changing given comments above from Tim and Chris. I suspect not many. The last one in the list could be; it's potentially user-facing and already has a nice exception message, so we can just change to `TypeError`. The ones in contrib.auth.hashers look like sanity checks we don't need to touch.
    79
    810{{{
    … …  
    3941django/views/decorators/debug.py:            assert isinstance(request, HttpRequest), (
    4042}}}
    41 
    42 The work to finish this off is to decide which ones remaining are worth changing given comments above from Tim and Chris. I suspect not many. The last one in the list could be; it's potentially user-facing and already has a nice exception message, so we can just change to `TypeError`. The ones in contrib.auth.hashers look like sanity checks we don't need to touch.
Back to Top