Changes between Initial Version and Version 1 of Ticket #32244


Ignore:
Timestamp:
Dec 4, 2020, 2:17:26 PM (4 years ago)
Author:
Lushen Wu
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32244 – Description

    initial v1  
    11Conceptual summary of the issue:
    2 Let's say we have a Django app with {{{Author}}} and {{{Book}}} models, and use a {{{BookFormSet}}} to add / modify / delete books that are created by a given {{{Author}}}. The problem is when the {{{BookFormSet}}} is validated, {{{ModelChoiceField.to_python()}}} ends up calling {{{self.queryset.get(id=123)}}} which results in a single-object SELECT query for **each** book in the formset. That means if I want to update 15 books, Django performs 15 separate SELECT queries, which seems incredibly inefficient. (Our actual app is an editor that can update any number of objects in a single formset, e.g. 50+).
     2Let's say we have a Django app with {{{Author}}} and {{{Book}}} models, and use a {{{BookFormSet}}} to add / modify / delete books that belong to a given {{{Author}}}. The problem is when the {{{BookFormSet}}} is validated, {{{ModelChoiceField.to_python()}}} ends up calling {{{self.queryset.get(id=123)}}} which results in a single-object SELECT query for **each** book in the formset. That means if I want to update 15 books, Django performs 15 separate SELECT queries, which seems incredibly inefficient. (Our actual app is an editor that can update any number of objects in a single formset, e.g. 50+).
    33
    44My failed attempts to solve this:
    551. First I tried passing a queryset to the {{{BookFormSet}}}, i.e. {{{formset = BookFormSet(data=request.POST, queryset=Book.objects.filter(author=1))}}}, but the `ModelChoiceField` still does its single-object SELECT queries.
    6 2. Then I tried to see where the {{{ModelChoiceField}}} defines its queryset, which seems to be in {{{BaseModelFormSet.add_fields()}}}. I tried initiating the {{{ModelChoiceField}}} with the same queryset that I passed to the formset, e.g. {{{Book.objects.filter(author=1)}}} instead of the original code which would be {{{Book._default_manager.get_queryset()}}}. But this doesn't help because I guess the new queryset I defined isn't actually linked to what was passed to the formset (and we don't have a cache running). So the multiple SELECT queries still happen. (Note: I realize {{{_default_manager.get_queryset}}} is necessary for use cases where you would want to switch one Model instance for another one which might not be in the original queryset passed to the {{{BaseModelFormset}}}, but this is not our use case)
     62. Then I tried to see where the {{{ModelChoiceField}}} defines its queryset, which seems to be in {{{BaseModelFormSet.add_fields()}}}. I tried initiating the {{{ModelChoiceField}}} with the same queryset that I passed to the formset, e.g. {{{Book.objects.filter(author=1)}}} instead of the original code which would be {{{Book._default_manager.get_queryset()}}}. But this doesn't help because I guess the new queryset I defined isn't actually linked to what was passed to the formset (and we don't have a cache running). So the multiple SELECT queries still happen. (Note: I realize {{{_default_manager.get_queryset()}}} might be necessary in cases where the formset can be used to switch one Model instance to another instance which might not be in the original queryset passed to the {{{BaseModelFormset}}}, but this is not our use case)
    773. I noticed that {{{BaseFormSet._existing_object()}}} provides a way to check whether an object exists in the queryset that was giving to the FormSet constructor, which means that queryset is evaluated at most once and the results stored in {{{BaseFormSet._object_dict}}}. I thought there might be some way to have {{{ModelChoiceField.to_python()}}} do something similar before calling {{{self.queryset.get(id=123)}}}, but I don't think {{{ModelChoiceField}}} is aware of {{{BaseFormSet}}}, and it would seem an anti-pattern to reach up the hierarchy like this.
    88
    9 The easiest solution seems to me to pass {{{BaseFormSet._object_dict}}} in some way to each {{{ModelForm}}} that's created, and then allow the {{{ModelChoiceField}}} to check {{{_object_dict}}} before making another SELECT query.
     9The easiest solution seems to me to pass {{{BaseFormSet._object_dict}}} in some way to each {{{ModelForm}}} that's created, and then allow the {{{ModelChoiceField}}} to check this {{{_object_dict}}} before making another SELECT query.
Back to Top