Changes between Initial Version and Version 1 of Ticket #32005, comment 3


Ignore:
Timestamp:
Sep 15, 2020, 3:27:57 AM (4 years ago)
Author:
Alex Vandiver

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32005, comment 3

    initial v1  
     1This is certainly tied to middleware ordering -- but I don't ''think'' that swapping the order up will fix it.
     2
    13Replying to [comment:2 Carlton Gibson]:
    24> Looks like you've just introduced this issue here https://github.com/zulip/zulip/commit/536bd3188e9428993fd712ed2f0df7c160b6ad60 🤔
     
    46That's the commit which introduces the need for it, and and works around its lack; you can see it cites this ticket in so doing.
    57
    6 As noted in that commit message, the LocaleMiddleware needs to be ''before'' the middleware that throws the 404, in order for the 404 page to be able to be properly localized.  That's what now causes the LocaleMiddleware to intercept the 404 and turn it into a 302.
     8As noted in that commit message, the LocaleMiddleware needs to be ''around'' the middleware that throws the 404, in order for the 404 page to be able to be properly localized.  If the LocaleMiddleware is inside it, then the 404 page actually gets the last localization that the thread served, in the previous request!  You can see this live if you bounce reload on https://nonexistent.zulipchat.com/ for a bit.
Back to Top