Changes between Version 3 and Version 4 of Ticket #31721


Ignore:
Timestamp:
Jun 18, 2020, 4:12:31 PM (4 years ago)
Author:
Klaas-Jan Gorter
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #31721 – Description

    v3 v4  
    2121        model = MyModel
    2222        formfield_callback = all_required
    23         fields = '__all__'
     23        fields = ['active', 'name']
    2424
    2525FactoryForm = forms.modelform_factory(MyModel, form=MyForm)
    2626}}}
    27 The expected behavior would be that the FactoryForm uses the formfield_callback specified in the Meta attribute of MyForm and that therefore the name-field would be required in both the FactoryForm and MyForm. However, under the current behavior of modelform_factory the formfield_callback is overwritten (with the default argument None) before the new class is constructed and in FactoryForm the name-field is not required.
     27The expected behavior would be that the FactoryForm uses the formfield_callback specified in the Meta attribute of MyForm and that therefore the fields would be required in both the FactoryForm and MyForm. However, under the current behavior of modelform_factory the formfield_callback is overwritten (with the default argument None) before the new class is constructed and in FactoryForm the fields are not required.
    2828
    2929I believe this is a bug, because this behavior has been observed before in Ticket [https://code.djangoproject.com/ticket/18573 #18573] in Django 1.3. The test that was proposed there was incorrect, because under the expected behavior the callback should have been called four times not two times as was asserted. (I believe this test has been removed from version 2, because I find no equivalent test in tests/model_formsets_regress.)
Back to Top