Remaining data.decode('ascii') @ hashers.py, but data is a str

[Marcel Nogueira d' Eurydice]

BCryptSHA256PasswordHasher class method enconde tries to decode data, but data is a str. In Python3 a str instance does not have a decode method.

def encode(self, password, salt):
        bcrypt = self._load_library()
        password = password.encode()
        # Hash the password prior to using bcrypt to prevent password
        # truncation as described in #20138.
        if self.digest is not None:
            # Use binascii.hexlify() because a hex encoded bytestring is str.
            password = binascii.hexlify(self.digest(password).digest())

        data = bcrypt.hashpw(password, salt)
        return "%s$%s" % (self.algorithm, data.decode('ascii'))

the return statement should be

        return "%s$%s" % (self.algorithm, data)

[Simon Charette]

bcrypt.hashpw returns bytes (and not str) which do have a .decode method and it's usage is necessary for the string interpolation into "%s$%s" to work properly.

>>> import bcrypt
>>> type(bcrypt.hashpw(b'password', bcrypt.gensalt()))
bytes

[naohide]

I'm facing the same issue. And tried to check type but I got str. I don't know why though..

import bcrypt
type(bcrypt.hashpw(b'password', bcrypt.gensalt()))
<class 'str'>

[Mariusz Felisiak]

naohide, probably because you're using Python 2 which is not supported.

[naohide]

Replying to felixxm:

naohide, probably because you're using Python 2 which is not supported.

no, I'm using Python3.8.5.

[naohide]

I checked _bcrypt.py and this might be the reason. I'm using ​https://pypi.org/project/py-bcrypt/ and called this package's bcrypt.

What do you guys use normally?

# encoding: utf-8
# module bcrypt._bcrypt
# from /.virtualenvs/project/lib/python3.8/site-packages/bcrypt/_bcrypt.cpython-38-darwin.so
# by generator 1.145
""" Internal module used by bcrypt. """

[naohide]

Replying to naohide:

I checked _bcrypt.py and this might be the reason. I'm using ​https://pypi.org/project/py-bcrypt/ and called this package's bcrypt.

What do you guys use normally?

# encoding: utf-8
# module bcrypt._bcrypt
# from /.virtualenvs/project/lib/python3.8/site-packages/bcrypt/_bcrypt.cpython-38-darwin.so
# by generator 1.145
""" Internal module used by bcrypt. """

got it. I changed py-bcrypt to ​https://pypi.org/project/bcrypt/ and worked fine for me!