Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#31577 closed Cleanup/optimization (fixed)

The explanation ended in the middle.

Reported by: Joon Hwan 김준환 Owned by: Joon Hwan 김준환
Component: Documentation Version: 3.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

​https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#range-fields
​https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#integerrangefield
​https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#bigintegerrangefield
​https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#daterangefield

You can see the sentence ends with "that is [)."

Change History (12)

comment:1 by Carlton Gibson, 6 years ago

This is how Postres ranges are specified. See ​https://www.postgresql.org/docs/9.3/rangetypes.html#RANGETYPES-IO

Wonder if we can explain that better.

comment:2 by Mariusz Felisiak, 6 years ago

Yes, see ​https://www.postgresql.org/docs/current/rangetypes.html#RANGETYPES-INCLUSIVITY.

We can only add ref to the PostgreSQL documentation like in ​RangeBoundary.

comment:3 by Carlton Gibson, 6 years ago

Resolution: → wontfix
Status: new → closed

Hmmm. We already link to the psycopg docs here: ​https://www.psycopg.org/docs/extras.html#adapt-range.

I'm going to say wontfix, as the [) is already marked out as a code literal. But if anyone wants to suggest a concrete clarification I'm happy to review.

in reply to:  3 comment:4 by Joon Hwan 김준환, 6 years ago

I had difficulty reading the document because I didn't have any background knowledge of Range Boundary expression.
I carefully suggests putting the next link nearby Range Fields.
​https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#rangeboundary-expressions

Version 0, edited 6 years ago by Joon Hwan 김준환 (next)

comment:5 by Carlton Gibson, 6 years ago

A PR clarifying would be very welcome. Please assign yourself and reopen the ticket if you will provide one. Thanks!

comment:6 by Joon Hwan 김준환, 6 years ago

Resolution: wontfix
Status: closed → new

Let me provide PR as soon as possible.

comment:7 by Joon Hwan 김준환, 6 years ago

Owner: changed from nobody to Joon Hwan 김준환
Status: new → assigned

comment:8 by Carlton Gibson, 5 years ago

Triage Stage: Unreviewed → Accepted

OK, super. I shall Accept on that basis.

Thanks for the input! 🎉

comment:9 by Joon Hwan 김준환, 5 years ago

Has patch: set

​PR

comment:10 by Mariusz Felisiak, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:11 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 4029bcd6:

Fixed #31577 -- Clarified docs about bounds of RangeFields.

comment:12 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 03bfcba:

[3.1.x] Fixed #31577 -- Clarified docs about bounds of RangeFields.

Backport of 4029bcd6b20f75a78f9a5829d7826c79aeb20732 from master

Note: See TracTickets for help on using tickets.
Back to Top