Opened 5 years ago

Closed 5 years ago

#31569 closed Cleanup/optimization (fixed)

Add support for GEOS 3.8.

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: pope1ni, Sergey Fedoseev Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Mariusz Felisiak)

Two tests fail with GEOS 3.8.1: Edit: My mistake I checked with wrong version.

======================================================================
FAIL: test_diff_intersection_union (gis_tests.geoapp.test_functions.GISFunctionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib/python3.6/unittest/case.py", line 605, in run
    testMethod()
  File "/repo/django/django/test/testcases.py", line 1215, in skip_wrapper
    return test_func(*args, **kwargs)
  File "/repo/django/tests/gis_tests/geoapp/test_functions.py", line 569, in test_diff_intersection_union
    self.assertEqual(c.mpoly.intersection(geom), c.intersection)
  File "/usr/lib/python3.6/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.6/unittest/case.py", line 822, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: <Point object at 0x7f614c615230> != <GeometryCollection object at 0x7f614c61e098>

======================================================================
FAIL: test_intersection (gis_tests.geoapp.test_functions.GISFunctionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib/python3.6/unittest/case.py", line 605, in run
    testMethod()
  File "/repo/django/django/test/testcases.py", line 1215, in skip_wrapper
    return test_func(*args, **kwargs)
  File "/repo/django/tests/gis_tests/geoapp/test_functions.py", line 299, in test_intersection
    self.assertEqual(c.inter, expected)
  File "/usr/lib/python3.6/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.6/unittest/case.py", line 822, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: <GeometryCollection object at 0x7f614c61ea28> != <Point object at 0x7f614c61e560>

Change History (5)

comment:1 by Mariusz Felisiak, 5 years ago

Cc: pope1ni Sergey Fedoseev added
Description: modified (diff)
Owner: Mariusz Felisiak removed
Status: assigned → new
Version: 3.0 → master

comment:2 by Mariusz Felisiak, 5 years ago

It's probably related with ​https://trac.osgeo.org/geos/ticket/1001. GEOS 3.8.1 works as expected.

Last edited 5 years ago by Mariusz Felisiak (previous) (diff)

comment:3 by Mariusz Felisiak, 5 years ago

Description: modified (diff)

comment:4 by Mariusz Felisiak, 5 years ago

Has patch: set
Owner: set to Mariusz Felisiak
Status: new → assigned

​PR

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 17ea7cc9:

Fixed #31569 -- Confirmed support for GEOS 3.8.

Note: See TracTickets for help on using tickets.
Back to Top