#31490 closed Uncategorized (needsinfo)
Increase length of contrib.sites domain field
Reported by: | thenewguy | Owned by: | nobody |
---|---|---|---|
Component: | contrib.sites | Version: | 3.0 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The domain value is currently limited to 100 characters. This seems like an arbitrary limit. Apps served via cloud providers like AWS can approach this limit pretty easily when accessed via their public path -> for example I just checked a few apps available through AWS load balancers and their FQDN was around 90 characters.
It isn't unfeasible for deeply nested domains to hit this limit either. Since many apps rely on the site record, these sites are dangerously close to not working with Django.
It would be helpful here to increase the size to the max portable length of a charfield at 255 characters.
Change History (1)
comment:1 by , 5 years ago
Resolution: | → needsinfo |
---|---|
Status: | new → closed |
Hi.
I'm not entirely convinced here.
It's the kind of change that needs consensus on the DevelopersMailingList.