Opened 6 years ago
Closed 6 years ago
#31441 closed Bug (fixed)
TabluarInline will not auto unhide/expand when classes = ['collapse'] and there is error during the saving process in django admin
| Reported by: | Jian | Owned by: | Hasan Ramezani |
|---|---|---|---|
| Component: | contrib.admin | Version: | 3.0 |
| Severity: | Normal | Keywords: | admin.TabularInline |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Attachments (3)
Change History (13)
by , 6 years ago
| Attachment: | StackedInline.png added |
|---|
by , 6 years ago
| Attachment: | TabularInline1.png added |
|---|
by , 6 years ago
| Attachment: | TabularInline2.png added |
|---|
comment:1 by , 6 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 6 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 6 years ago
I checked it. There are 3 problems when there is an error during the save:
- admin.TabularInline will not show a red border
- admin.TabularInline will not expand
- admin.TabularInline and admin.StackedInline will not show
Hidelink when there is an error and formset is expanded
I am going to prepare a patch to address these 3 issues.
comment:5 by , 6 years ago
| Patch needs improvement: | set |
|---|
comment:6 by , 6 years ago
| Patch needs improvement: | unset |
|---|
comment:7 by , 6 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:8 by , 6 years ago
admin.TabularInline and admin.StackedInline will not show Hide link when there is an error and formset is expanded
I'm inclined to think we can leave that. That it's a feature: if there's an error don't let you collapse the inline, so you can't forget about it.
(No doubt X years from now, such ticket is opened... :)
I'm not 100% against but there's probably a better use of time.
Hi Jian. This looks valid. Thanks for the report. Do you fancy trying to resolve it?