Changes between Version 7 and Version 8 of Ticket #31416, comment 8


Ignore:
Timestamp:
Apr 12, 2020, 10:11:10 PM (4 years ago)
Author:
Nan Liu

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #31416, comment 8

    v7 v8  
    1111
    1212
    13 hi Sanskar, I am still working on this issue. it may take a longer time for me to fix it since I am a newbie. since this is for my school assignment, may you work on other issues or if it would be much better if we can solve it together? I really appreciate that! And I think the operations for you weren't swapped maybe because you didn't add a dependency of the removed field for all its bases?
     13hi Sanskar, I am still working on this issue. it may take a longer time for me to fix it since I am a newbie. since this is for my school assignment, may you work on other issues or if it would be much better if we can solve it together? I really appreciate that!
    1414
    15 I was able to swap the operations when I appended a `manual dependency` on field removal of all of its bases in `generate_created_models`. If you don't mind me asking, how am I able to know that is the field we are tryna remove? I am reading the code currently, but i will still leave this "dumb" question here just in case I don't find it by the time.
     15And I think the operations for you weren't swapped maybe because you didn't add a dependency of the removed field for all its bases? And also adjusting `check_dependency` seems unnecessary since it already handles everything well from my testing.
    1616
    17 In addition, in terms of possible duplicate `Remove_fields`, I wasn't able to generate multiple same `Remove_fields` for `title`, so i guess this is already handled somewhere in the code?
     17I was able to swap the operations when I appended a `manual dependency` on field removal of all of its bases in `generate_created_models`. If you don't mind me asking, how am I able to know that is the field we are tryna remove? I am reading the code currently, but I will still leave this "dumb" question here just in case I don't find it by the time.
    1818
     19In addition, in terms of possible duplicate `Remove_fields`, I wasn't able to generate multiple same `Remove_fields` for `title`, so I guess this is already handled somewhere in the code?
     20
Back to Top