Changes between Initial Version and Version 1 of Ticket #31358, comment 33


Ignore:
Timestamp:
04/21/2020 03:06:50 PM (10 months ago)
Author:
Jon Moroney
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31358, comment 33

    initial v1  
    33In essence that makes for a two stage check I think. Should it just be convention for a hasher to return `super().must_update` rather than ever returning false?
    44
    5 After a bit of a struggle with the bcrypt hasher I've squashed it down to a single commit. It looks like bcrypt is using more than just the salt stored data as a salt in hash verification. I've added a bit more logic to handle matching what was used, but if you wouldn't mind giving it a second look that would be helpful :) I've left the relevant changes in the most recent commit on the PR.
     5After a bit of a struggle with the bcrypt hasher I've squashed the PR down. It looks like bcrypt is using more than just the salt stored data as a salt in hash verification. I've added a bit more logic to handle matching what was used, but if you wouldn't mind giving it a second look that would be helpful :) I've left the relevant changes in the most recent commit on the PR.
Back to Top