Changes between Version 5 and Version 6 of Ticket #31093


Ignore:
Timestamp:
Dec 15, 2019, 8:42:29 AM (4 years ago)
Author:
James Pic
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31093 – Description

    v5 v6  
    3434The admin views could use this, and django.contrib.auth could provide generic views extensions which do check permissions, removing the need to share a mixin that just does return a Mixin with a get_queryset method to complement the code that they have in the permission backend. It would reduce chances to make a mistake when updating permission code if it's all at the same place, an opinion that I consider suited for a framework like Django.
    3535
    36 I consider that the subject of making ModelChoiceFields to be able to benefit from this is out of the scope of this ticket, but I could bring it up for discussion if this feature is implemented.
     36I consider that the subject of making ModelChoiceFields to be able to benefit from this is out of the scope of this ticket, but I could bring it up for discussion if this feature is implemented (ie. DRF serializers have a "context" variables where the request object is set by default, which allows to do user-based validation: a pretty standard requirement).
Back to Top