Changes between Initial Version and Version 1 of Ticket #31071, comment 6


Ignore:
Timestamp:
12/07/19 05:38:17 (3 years ago)
Author:
Simon Charette
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31071, comment 6

    initial v1  
    33Note that this limitation was mentioned in https://code.djangoproject.com/ticket/29260#comment:3 so another option could be to document that `force_update` must be used in this particular case. I feel like this would be good compromise. Regarding the fixture loading we should branch of `raw` [https://github.com/django/django/blob/master/django/core/serializers/base.py#L219-L223 which is passed by the serialization framework] to disable the optimiation.
    44
    5 Happy to provide a patch for whatever solution we choose. I think it's worth adjusting the feature given and documenting it as a backward incompatible change that be worked around by passing `force_update` but simply reverting the feature and reopening #29260 to target the next release is likely less trouble.
     5Happy to provide a patch for whatever solution we choose. I think it's worth adjusting the feature given it does reduce the number of queries significantly when using primary key defaults and documenting it as a backward incompatible change that can be worked around by passing `force_update` but simply reverting the feature and reopening #29260 to target the next release is likely less trouble.
Back to Top