Opened 5 years ago
Last modified 5 years ago
#30941 closed Bug
hasattr(request, '_cached_user') check no longer works — at Initial Version
| Reported by: | Collin Anderson | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.auth | Version: | dev |
| Severity: | Release blocker | Keywords: | |
| Cc: | cmawebsite@…, Sergey Fedoseev, Simon Charette | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Before 2f01079, it was possible to check to see whether the lazy user has been evaluated or not using hasattr(request, '_cached_user'). This was undocumented, but used a lot: https://github.com/search?q=_cached_user&type=Code
I think we should try to maintain backwards compatibility for that that check, and document and test it. (Or if nothing else, document and test the new behavior and add a release note.)
This is really helpful in middleware to be able to check this, so you can access the user if it has already been accessed, but can avoid fetching user if it hasn't already been fetched.
Note:
See TracTickets
for help on using tickets.