Changes between Initial Version and Version 1 of Ticket #30931, comment 7


Ignore:
Timestamp:
Oct 31, 2019, 4:29:29 AM (5 years ago)
Author:
Carlton Gibson

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30931, comment 7

    initial v1  
    4444This approach requires overriding `_get_FIELD_display()` **before** declaring fields on 2.1, because otherwise `Model._get_FIELD_display()` is picked up during `Field.contribute_to_class()`. This ordering dependency is, ultimately, the same issue that was addressed in a68ea231012434b522ce45c513d84add516afa60, and the follow-up in #30254.
    4545
    46 The behaviour is 2.1 and before was incorrect. Yes, there's a behaviour change here but it's a bugfix, and all bugfixes are breaking changes if you're depending on the broken behaviour.
     46The behaviour in 2.1 (and before) was incorrect. Yes, there's a behaviour change here but it's a bugfix, and all bugfixes are breaking changes if you're depending on the broken behaviour.
    4747
    4848I'm going to downgrade this from Release Blocker accordingly. I'll reclassify this as a Documentation issue and provide the working example, as overriding `_get_FIELD_display()` is a legitimate use-case I'd guess.
Back to Top