timesince() ignores time_strings argument for the same dates.

[Bas Van Gaalen]

In the code, when delta is datetime.timedelta(0) (line 66), the condition since <= 0 becomes true (line 70) and the function will return this:
return avoid_wrapping(gettext('0 minutes')) (line 72)

This should probably be:
return avoid_wrapping(time_strings['minute'] % 0)

Or alternatively the condition could be changed to since < 0.

[Mariusz Felisiak]

Thanks for this report. I'm not sure if it's an issue for any language but I agree that we should use time_strings['minute'] % 0.

[Hasan Ramezani]

​PR

[Mariusz Felisiak]

Note: ​naturaltime doesn't fall back to timesince() if the value is less than a day old, moreover the time_string argument is not documented, so it's not an issue in supported use cases. However, I agree that we can change this for consistency because someone can use timesince()/timeuntil() in custom filters.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 52cb4190:

Fixed #30918 -- Made timesince()/timeuntil() respect custom time strings for future and the same datetimes.