Opened 5 years ago

Last modified 5 years ago

#30880 closed Cleanup/optimization

Optimize the _tx_resource_for_name() function in django/scripts/manage_translations.py — at Version 1

Reported by: ankit1219 Owned by: nobody
Component: Core (Other) Version: dev
Severity: Normal Keywords: Optimize scripts
Cc: asrokx917@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by ankit1219)

The _tx_resource_for_name() function in django/scripts/manage_translations.py uses simple if else statement to return the Transifex resource name.

def _tx_resource_for_name(name):

if name == 'core':

return "django.core"

else:

return "django.contrib-%s" % name

You can use Python ternary operator to reduce code size and increase readability of the code.

def _tx_resource_for_name(name):

return "django.core" if name == 'core' else "django.contrib-%s" % name

It allows us to replace simple if statements with a single line expression. Increases code readability by reducing number of lines of code.

Change History (1)

comment:1 by ankit1219, 5 years ago

Description: modified (diff)

I can send a PR to optimize the code.

Note: See TracTickets for help on using tickets.
Back to Top