Changes between Initial Version and Version 1 of Ticket #30866
- Timestamp:
- Oct 10, 2019, 9:28:11 AM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #30866 – Description
initial v1 1 1 The tests in `tests/view_tests/tests/test_debug.py` are all (for want of a better phrase) ''integration level'' — they test whether particular values appear in the final output of either HTML, Plain Text, or either version of the email that's sent to admins. 2 2 3 The trouble with this is that there's lot's of duplicate testing. As is inevitable, the tests are subtl ey out of sync. There are gaps in coverage, for instance in testing whether settings overrides actually work. And most, for me, looking at resolving the outstanding Error Reporting issues at the moment, it's **hard** to keep in mind exactly what tests should go where.3 The trouble with this is that there's lot's of duplicate testing. As is inevitable, the tests are subtly out of sync. There are gaps in coverage, for instance in testing whether settings overrides actually work. And most, for me, looking at resolving the outstanding Error Reporting issues at the moment, it's **hard** to keep in mind exactly what tests should go where. 4 4 5 5 As such, I'd like to refactor the tests. I'm just about to take that on, but I wanted to confirm that it would be OK before doing so. Coverage will be maintained. The tests will be clearer and just as effective, if not more so, and much easier to comprehend/maintain. … … 13 13 Additional tests can then focus on format specific questions, such as whether the correct format is used for Ajax requests, rather than repeating the filtering logic multiple times. 14 14 15 As I say, primed to go but, wanting to confirm and record the intention .15 As I say, primed to go but, wanting to confirm and record the intention, because it's a change in strategy.