Changes between Initial Version and Version 1 of Ticket #30841, comment 5


Ignore:
Timestamp:
Oct 5, 2019, 12:47:20 PM (5 years ago)
Author:
Mariusz Felisiak

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30841, comment 5

    initial v1  
    1 After the reconsideration I don't think that we should change this [https://docs.djangoproject.com/en/2.2/ref/models/querysets/#isnull documented] behavior (that is in Django from the very beginning). `__isnull` lookup expects boolean values in many places and IMO it would be confusing if we'll allow for truthy/falsy values, e.g. take a look at these examples `field__isnull='false'` or `field__isnull='true'` (both would return the same result).
     1After the reconsideration I don't think that we should change this [https://docs.djangoproject.com/en/2.2/ref/models/querysets/#isnull documented] behavior (that is in Django from the very beginning). `__isnull` lookup expects boolean values in many places and IMO it would be confusing if we'll allow for truthy/falsy values, e.g. take a look at these examples `field__isnull='false'` or `field__isnull='true'` (both would return the same result). You can always call `bool()` on a right hand side.
    22
    33Sorry for my previous acceptation (I shouldn't triage tickets in the weekend).
Back to Top