Changes between Initial Version and Version 1 of Ticket #30807, comment 4
- Timestamp:
- Sep 29, 2019, 5:51:21 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #30807, comment 4
initial v1 1 1 Having now read back the history of the previous tickets (#26494 and #27628) a few thoughts: 2 2 3 `_copy_permissions` was introduced in #27628 to ensure files remain readable by the o wner so that files extracted from an archive remain readable (and thus executable), even if they do not have those permissions set within the archive.3 `_copy_permissions` was introduced in #27628 to ensure files remain readable by the other so that files extracted from an archive remain readable (and thus executable), even if they do not have those permissions set within the archive. 4 4 5 5 It seems we have (at least) two options: 6 6 7 1. Rather than checking it has o wner-read (`stat.S_IROTH`) we could do a bit-wise ORto ensure owner-read on all extracted files7 1. Rather than checking it has other-read (`stat.S_IROTH`) we could do a bit-wise OR with owner-read to ensure owner-read on all extracted files 8 8 (which is what is happening now too, but in current state group & world permissions are now set to OS default instead of what is set in the archive) 9 9