Changes between Initial Version and Version 1 of Ticket #30776, comment 6


Ignore:
Timestamp:
Sep 18, 2019, 3:47:22 AM (5 years ago)
Author:
Carlton Gibson

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #30776, comment 6

    initial v1  
    99... I think I prefer setting `max_length` in `UsernameField.__init__()`, if not passed as a kwarg, and so leveraging `CharField`'s auto-adding the validator.
    1010(Validating the POST data seems the best chance to error early, even if we're trying an INSERT...)
     11
     12
     13**Update**: Bit too quick there. This issue only affects `AuthenticationForm` so it looks like we must pass the kwarg, or adjust in the form `__init__()` method, otherwise we're making a logic change to `UsernameField`. (Such may or may not be worth doing, but not on this ticket...)
Back to Top