Opened 5 years ago
Last modified 5 years ago
#30768 closed Bug
django.forms.boundfield.as_widget method hasn't been updated, and causes an exception when used! — at Version 1
| Reported by: | Mark | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | 2.2 |
| Severity: | Normal | Keywords: | boundfiled renderer |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
/django/forms/boundfield.py;90-95 calls widget.render() with 'rederer=self.form.renderer' on line 94
the renderer argument was removed in 2.1; <https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-in-2-1>
This should be very easy to fix; it looks like this method wasn't updated when the renderer argument was removed.
I commented out line 94 locally and it fixes the problem.
I just installed 2.2.5 to verify that this still existed, I also did a search of existing tickets, but couldn't find this reported yet.
edit: I just rechecked the patch submission guidlines, and I made the patch wrong, its just the output of 'diff boundfield.py oldboundfield.py'; its simply deleting line 94
Change History (2)
by , 5 years ago
| Attachment: | boundfield.py.diff added |
|---|
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|