Changes between Initial Version and Version 1 of Ticket #30766


Ignore:
Timestamp:
Sep 5, 2019, 3:27:56 PM (5 years ago)
Author:
Nasir Hussain
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #30766

    • Property Has patch set
    • Property Summary Refactor ExceptionReporter to allow overriding cookies filter. → Make it easier to override custom ExceptionReporter subclass functions.

  • Ticket #30766 – Description

    initial v1  
    1 Since now we are allowing to use custom ExceptionRepoter subclass in #29714. We should refactor ExceptionReporter and move [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319 cookies] extraction to a function like we are doing for POST [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305 here] so that It is easy to override sensitive cookies filtering in the custom subclass of ExceptionRepoter.
     1Since now we are allowing to use custom ExceptionRepoter subclass in #29714. We should refactor ExceptionReporter and move [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L319 cookies] extraction to a function like we are doing for POST [https://github.com/django/django/blob/350123f38c2b6217c38d70bfbd924a9ba3df1289/django/views/debug.py#L305 here] so that It is easy to override sensitive cookies filtering in the custom subclass of ExceptionRepoter. [https://github.com/django/django/pull/11748 Patch], I could add unit tests if required.
Back to Top