Changes between Initial Version and Version 1 of Ticket #30752, comment 7
- Timestamp:
- Sep 11, 2019, 4:18:48 AM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #30752, comment 7
initial v1 6 6 Looking at it, there's no nice way to pass down the exception reporter class so, I agree, a setting will be the easiest way forward. 7 7 8 Your PR looks more or less right, but I think we need to say more in the `Custom error reports` section . Specifically we should probably begin stating that the reports are created by the `ExceptionReporter` class, and that it uses an `ExceptionReporterFilter` to control the filtering. Then then existing filtering examples are OK — that's the first port of call ‚ before giving an override example for `ExceptionReporter`...8 Your PR looks more or less right, but I think we need to say more in the `Custom error reports` section of the docs. Specifically we should probably begin stating that the reports are created by the `ExceptionReporter` class, and that it uses an `ExceptionReporterFilter` to control the filtering. Then then existing filtering examples are OK — that's the first port of call ‚ before giving an override example for `ExceptionReporter`... 9 9 10 10 {{{